Explorar el Código

Switch the resolve action to push (#3998)

https://github.com/Ardiannn08/resolve-outdated-comment documents this as
using push. My guess is that's the root of
https://github.com/carbon-language/carbon-lang/actions/runs/9259644459/job/25471949664;
if this doesn't fix it, we'll probably just need to remove it.
Jon Ross-Perkins hace 1 año
padre
commit
52bf4e618c

+ 24 - 0
.github/workflows/pre_commit_resolve.yaml

@@ -0,0 +1,24 @@
+# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
+# Exceptions. See /LICENSE for license information.
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+name: 'Delete stale suggestions'
+
+on:
+  push:
+
+jobs:
+  delete-stale-suggestions:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
+        with:
+          egress-policy: audit
+
+      - name: Delete stale suggestions
+        uses: Ardiannn08/resolve-outdated-comment@3b3cf4b2651a84fac2d6a94c2aeca9ac7c05ac5f # v1.3
+        with:
+          token: ${{ secrets.CARBON_INFRA_BOT_FOR_REVIEWDOG }}
+          filter-user: 'CarbonInfraBot'
+          mode: 'delete'

+ 1 - 17
.github/workflows/pre_commit_suggestions.yaml

@@ -3,7 +3,7 @@
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 # Create PR suggestions based on problems found by pre-commit action.
-name: pre-commit-suggestions
+name: 'Add pre-commit suggestions'
 
 # This action is run whenever the `pre-commit` action finishes. Because the
 # `pre-commit` action is an unprivileged action running on (for example) the
@@ -60,19 +60,3 @@ jobs:
           cat ./diff | \
           GITHUB_EVENT_PATH=./event \
             reviewdog -f=diff -f.diff.strip=1 -reporter=github-pr-review
-
-  delete-stale-suggestions:
-    if: github.event.workflow_run.event == 'pull_request'
-    runs-on: ubuntu-latest
-    steps:
-      - name: Harden Runner
-        uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
-        with:
-          egress-policy: audit
-
-      - name: Delete stale suggestions
-        uses: Ardiannn08/resolve-outdated-comment@3b3cf4b2651a84fac2d6a94c2aeca9ac7c05ac5f # v1.3
-        with:
-          token: ${{ secrets.CARBON_INFRA_BOT_FOR_REVIEWDOG }}
-          filter-user: 'CarbonInfraBot'
-          mode: 'delete'