check_unit.cpp 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612
  1. // Part of the Carbon Language project, under the Apache License v2.0 with LLVM
  2. // Exceptions. See /LICENSE for license information.
  3. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  4. #include "toolchain/check/check_unit.h"
  5. #include <iterator>
  6. #include <string>
  7. #include <tuple>
  8. #include <utility>
  9. #include "clang/Sema/Sema.h"
  10. #include "common/growing_range.h"
  11. #include "common/pretty_stack_trace_function.h"
  12. #include "llvm/ADT/IntrusiveRefCntPtr.h"
  13. #include "llvm/ADT/StringRef.h"
  14. #include "llvm/Support/VirtualFileSystem.h"
  15. #include "toolchain/base/fixed_size_value_store.h"
  16. #include "toolchain/base/kind_switch.h"
  17. #include "toolchain/check/cpp/generate_ast.h"
  18. #include "toolchain/check/cpp/import.h"
  19. #include "toolchain/check/diagnostic_helpers.h"
  20. #include "toolchain/check/generic.h"
  21. #include "toolchain/check/handle.h"
  22. #include "toolchain/check/impl.h"
  23. #include "toolchain/check/impl_lookup.h"
  24. #include "toolchain/check/impl_validation.h"
  25. #include "toolchain/check/import.h"
  26. #include "toolchain/check/import_ref.h"
  27. #include "toolchain/check/inst.h"
  28. #include "toolchain/check/node_id_traversal.h"
  29. #include "toolchain/check/type.h"
  30. #include "toolchain/check/type_structure.h"
  31. #include "toolchain/diagnostics/diagnostic.h"
  32. #include "toolchain/sem_ir/function.h"
  33. #include "toolchain/sem_ir/ids.h"
  34. #include "toolchain/sem_ir/import_ir.h"
  35. #include "toolchain/sem_ir/typed_insts.h"
  36. namespace Carbon::Check {
  37. // Returns the number of imported IRs, to assist in Context construction.
  38. static auto GetImportedIRCount(UnitAndImports* unit_and_imports) -> int {
  39. int count = 0;
  40. for (auto& package_imports : unit_and_imports->package_imports) {
  41. count += package_imports.imports.size();
  42. }
  43. if (!unit_and_imports->api_for_impl) {
  44. // Leave an empty slot for `ImportIRId::ApiForImpl`.
  45. ++count;
  46. }
  47. if (!unit_and_imports->cpp_imports.empty()) {
  48. // Leave an empty slot for `ImportIRId::Cpp`.
  49. ++count;
  50. }
  51. return count;
  52. }
  53. CheckUnit::CheckUnit(
  54. UnitAndImports* unit_and_imports,
  55. const Parse::GetTreeAndSubtreesStore* tree_and_subtrees_getters,
  56. llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> fs,
  57. std::shared_ptr<clang::CompilerInvocation> clang_invocation,
  58. llvm::raw_ostream* vlog_stream)
  59. : unit_and_imports_(unit_and_imports),
  60. tree_and_subtrees_getter_(tree_and_subtrees_getters->Get(
  61. unit_and_imports->unit->sem_ir->check_ir_id())),
  62. fs_(std::move(fs)),
  63. clang_invocation_(std::move(clang_invocation)),
  64. emitter_(&unit_and_imports_->err_tracker, tree_and_subtrees_getters,
  65. unit_and_imports_->unit->sem_ir),
  66. context_(&emitter_, tree_and_subtrees_getter_,
  67. unit_and_imports_->unit->sem_ir,
  68. GetImportedIRCount(unit_and_imports),
  69. unit_and_imports_->unit->total_ir_count, vlog_stream) {}
  70. auto CheckUnit::Run() -> void {
  71. Timings::ScopedTiming timing(unit_and_imports_->unit->timings, "check");
  72. // We can safely mark this as checked at the start.
  73. unit_and_imports_->is_checked = true;
  74. PrettyStackTraceFunction context_dumper(
  75. [&](llvm::raw_ostream& output) { context_.PrintForStackDump(output); });
  76. // Add a block for the file.
  77. context_.inst_block_stack().Push();
  78. InitPackageScopeAndImports();
  79. // Eagerly import the impls declared in the api file to prepare to redeclare
  80. // them.
  81. ImportImplsFromApiFile(context_);
  82. if (!ProcessNodeIds()) {
  83. context_.sem_ir().set_has_errors(true);
  84. return;
  85. }
  86. FinishRun();
  87. }
  88. auto CheckUnit::InitPackageScopeAndImports() -> void {
  89. // Importing makes many namespaces, so only canonicalize the type once.
  90. auto namespace_type_id =
  91. GetSingletonType(context_, SemIR::NamespaceType::TypeInstId);
  92. // Use the name of the package for the package scope.
  93. SemIR::NameId package_name_id = SemIR::NameId::MainPackage;
  94. const auto& packaging = context_.parse_tree().packaging_decl();
  95. if (packaging && packaging->names.package_id.has_value()) {
  96. package_name_id =
  97. SemIR::NameId::ForPackageName(packaging->names.package_id);
  98. }
  99. // Define the package scope, with an instruction for `package` expressions to
  100. // reference.
  101. auto package_scope_id =
  102. context_.name_scopes().Add(SemIR::Namespace::PackageInstId,
  103. package_name_id, SemIR::NameScopeId::None);
  104. CARBON_CHECK(package_scope_id == SemIR::NameScopeId::Package);
  105. auto package_inst_id =
  106. AddInst<SemIR::Namespace>(context_, Parse::NodeId::None,
  107. {.type_id = namespace_type_id,
  108. .name_scope_id = SemIR::NameScopeId::Package,
  109. .import_id = SemIR::InstId::None});
  110. CARBON_CHECK(package_inst_id == SemIR::Namespace::PackageInstId);
  111. // Call `SetSpecialImportIRs()` to set `ImportIRId::ApiForImpl` and
  112. // `ImportIRId::Cpp` first, as required.
  113. if (unit_and_imports_->api_for_impl) {
  114. const auto& names = packaging->names;
  115. auto import_decl_id = AddInst<SemIR::ImportDecl>(
  116. context_, names.node_id,
  117. {.package_id = SemIR::NameId::ForPackageName(names.package_id)});
  118. SetSpecialImportIRs(
  119. context_, {.decl_id = import_decl_id,
  120. .is_export = false,
  121. .sem_ir = unit_and_imports_->api_for_impl->unit->sem_ir});
  122. } else {
  123. SetSpecialImportIRs(context_,
  124. {.decl_id = SemIR::InstId::None, .sem_ir = nullptr});
  125. }
  126. // Add import instructions for everything directly imported. Implicit imports
  127. // are handled separately.
  128. for (auto& package_imports : unit_and_imports_->package_imports) {
  129. CARBON_CHECK(!package_imports.import_decl_id.has_value());
  130. package_imports.import_decl_id = AddInst<SemIR::ImportDecl>(
  131. context_, package_imports.node_id,
  132. {.package_id =
  133. SemIR::NameId::ForPackageName(package_imports.package_id)});
  134. }
  135. // Process the imports.
  136. if (unit_and_imports_->api_for_impl) {
  137. ImportApiFile(context_, namespace_type_id,
  138. *unit_and_imports_->api_for_impl->unit->sem_ir);
  139. }
  140. ImportCurrentPackage(package_inst_id, namespace_type_id);
  141. CARBON_CHECK(context_.scope_stack().PeekIndex() == ScopeIndex::Package);
  142. ImportOtherPackages(namespace_type_id);
  143. const auto& cpp_imports = unit_and_imports_->cpp_imports;
  144. if (!cpp_imports.empty()) {
  145. ImportCpp(context_, cpp_imports, fs_, clang_invocation_);
  146. }
  147. }
  148. auto CheckUnit::CollectDirectImports(
  149. llvm::SmallVector<SemIR::ImportIR>& results,
  150. CheckIRIdToIntStore& ir_to_result_index, SemIR::InstId import_decl_id,
  151. const PackageImports& imports, bool is_local) -> void {
  152. for (const auto& import : imports.imports) {
  153. const auto& direct_ir = *import.unit_info->unit->sem_ir;
  154. auto& index = ir_to_result_index.Get(direct_ir.check_ir_id());
  155. if (index != -1) {
  156. // This should only happen when doing API imports for an implementation
  157. // file. Don't change the entry; is_export doesn't matter.
  158. continue;
  159. }
  160. index = results.size();
  161. results.push_back({.decl_id = import_decl_id,
  162. // Only tag exports in API files, ignoring the value in
  163. // implementation files.
  164. .is_export = is_local && import.names.is_export,
  165. .sem_ir = &direct_ir});
  166. }
  167. }
  168. auto CheckUnit::CollectTransitiveImports(SemIR::InstId import_decl_id,
  169. const PackageImports* local_imports,
  170. const PackageImports* api_imports)
  171. -> llvm::SmallVector<SemIR::ImportIR> {
  172. llvm::SmallVector<SemIR::ImportIR> results;
  173. // Track whether an IR was imported in full, including `export import`. This
  174. // distinguishes from IRs that are indirectly added without all names being
  175. // exported to this IR.
  176. auto ir_to_result_index = CheckIRIdToIntStore::MakeWithExplicitSize(
  177. unit_and_imports_->unit->total_ir_count, -1);
  178. // First add direct imports. This means that if an entity is imported both
  179. // directly and indirectly, the import path will reflect the direct import.
  180. if (local_imports) {
  181. CollectDirectImports(results, ir_to_result_index, import_decl_id,
  182. *local_imports,
  183. /*is_local=*/true);
  184. }
  185. if (api_imports) {
  186. CollectDirectImports(results, ir_to_result_index, import_decl_id,
  187. *api_imports,
  188. /*is_local=*/false);
  189. }
  190. // Loop through direct imports for any indirect exports. The underlying vector
  191. // is appended during iteration, so take the size first.
  192. const int direct_imports = results.size();
  193. for (int direct_index : llvm::seq(direct_imports)) {
  194. bool is_export = results[direct_index].is_export;
  195. for (const auto& indirect_ir :
  196. results[direct_index].sem_ir->import_irs().values()) {
  197. if (!indirect_ir.is_export) {
  198. continue;
  199. }
  200. auto& indirect_index =
  201. ir_to_result_index.Get(indirect_ir.sem_ir->check_ir_id());
  202. if (indirect_index == -1) {
  203. indirect_index = results.size();
  204. // TODO: In the case of a recursive `export import`, this only points at
  205. // the outermost import. May want something that better reflects the
  206. // recursion.
  207. results.push_back({.decl_id = results[direct_index].decl_id,
  208. .is_export = is_export,
  209. .sem_ir = indirect_ir.sem_ir});
  210. } else if (is_export) {
  211. results[indirect_index].is_export = true;
  212. }
  213. }
  214. }
  215. return results;
  216. }
  217. auto CheckUnit::ImportCurrentPackage(SemIR::InstId package_inst_id,
  218. SemIR::TypeId namespace_type_id) -> void {
  219. // Add imports from the current package.
  220. auto import_map_lookup =
  221. unit_and_imports_->package_imports_map.Lookup(PackageNameId::None);
  222. if (!import_map_lookup) {
  223. // Push the scope; there are no names to add.
  224. context_.scope_stack().PushForEntity(
  225. package_inst_id, SemIR::NameScopeId::Package, SemIR::SpecificId::None,
  226. /*lexical_lookup_has_load_error=*/false);
  227. return;
  228. }
  229. PackageImports& self_import =
  230. unit_and_imports_->package_imports[import_map_lookup.value()];
  231. if (self_import.has_load_error) {
  232. context_.name_scopes().Get(SemIR::NameScopeId::Package).set_has_error();
  233. }
  234. ImportLibrariesFromCurrentPackage(
  235. context_, namespace_type_id,
  236. CollectTransitiveImports(self_import.import_decl_id, &self_import,
  237. /*api_imports=*/nullptr));
  238. context_.scope_stack().PushForEntity(
  239. package_inst_id, SemIR::NameScopeId::Package, SemIR::SpecificId::None,
  240. context_.name_scopes().Get(SemIR::NameScopeId::Package).has_error());
  241. }
  242. auto CheckUnit::ImportOtherPackages(SemIR::TypeId namespace_type_id) -> void {
  243. // api_imports_list is initially the size of the current file's imports,
  244. // including for API files, for simplicity in iteration. It's only really used
  245. // when processing an implementation file, in order to combine the API file
  246. // imports.
  247. //
  248. // For packages imported by the API file, the PackageNameId is the package
  249. // name and the index is into the API's import list. Otherwise, the initial
  250. // {None, -1} state remains.
  251. llvm::SmallVector<std::pair<PackageNameId, int32_t>> api_imports_list;
  252. api_imports_list.resize(unit_and_imports_->package_imports.size(),
  253. {PackageNameId::None, -1});
  254. // When there's an API file, add the mapping to api_imports_list.
  255. if (unit_and_imports_->api_for_impl) {
  256. const auto& api_identifiers =
  257. unit_and_imports_->api_for_impl->unit->value_stores->identifiers();
  258. auto& impl_identifiers =
  259. unit_and_imports_->unit->value_stores->identifiers();
  260. for (auto [api_imports_index, api_imports] :
  261. llvm::enumerate(unit_and_imports_->api_for_impl->package_imports)) {
  262. // Skip the current package.
  263. if (!api_imports.package_id.has_value()) {
  264. continue;
  265. }
  266. // Translate the package ID from the API file to the implementation file.
  267. auto impl_package_id = api_imports.package_id;
  268. if (auto package_identifier_id = impl_package_id.AsIdentifierId();
  269. package_identifier_id.has_value()) {
  270. impl_package_id = PackageNameId::ForIdentifier(
  271. impl_identifiers.Add(api_identifiers.Get(package_identifier_id)));
  272. }
  273. if (auto lookup =
  274. unit_and_imports_->package_imports_map.Lookup(impl_package_id)) {
  275. // On a hit, replace the entry to unify the API and implementation
  276. // imports.
  277. api_imports_list[lookup.value()] = {impl_package_id, api_imports_index};
  278. } else {
  279. // On a miss, add the package as API-only.
  280. api_imports_list.push_back({impl_package_id, api_imports_index});
  281. }
  282. }
  283. }
  284. for (auto [i, api_imports_entry] : llvm::enumerate(api_imports_list)) {
  285. // These variables are updated after figuring out which imports are present.
  286. auto import_decl_id = SemIR::InstId::None;
  287. PackageNameId package_id = PackageNameId::None;
  288. bool has_load_error = false;
  289. // Identify the local package imports if present.
  290. PackageImports* local_imports = nullptr;
  291. if (i < unit_and_imports_->package_imports.size()) {
  292. local_imports = &unit_and_imports_->package_imports[i];
  293. if (!local_imports->package_id.has_value()) {
  294. // Skip the current package.
  295. continue;
  296. }
  297. import_decl_id = local_imports->import_decl_id;
  298. package_id = local_imports->package_id;
  299. has_load_error |= local_imports->has_load_error;
  300. }
  301. // Identify the API package imports if present.
  302. PackageImports* api_imports = nullptr;
  303. if (api_imports_entry.second != -1) {
  304. api_imports = &unit_and_imports_->api_for_impl
  305. ->package_imports[api_imports_entry.second];
  306. if (local_imports) {
  307. CARBON_CHECK(package_id == api_imports_entry.first);
  308. } else {
  309. auto import_ir_inst_id =
  310. context_.import_ir_insts().Add(SemIR::ImportIRInst(
  311. SemIR::ImportIRId::ApiForImpl, api_imports->import_decl_id));
  312. import_decl_id =
  313. AddInst(context_, MakeImportedLocIdAndInst<SemIR::ImportDecl>(
  314. context_, import_ir_inst_id,
  315. {.package_id = SemIR::NameId::ForPackageName(
  316. api_imports_entry.first)}));
  317. package_id = api_imports_entry.first;
  318. }
  319. has_load_error |= api_imports->has_load_error;
  320. }
  321. // Do the actual import.
  322. ImportLibrariesFromOtherPackage(
  323. context_, namespace_type_id, import_decl_id, package_id,
  324. CollectTransitiveImports(import_decl_id, local_imports, api_imports),
  325. has_load_error);
  326. }
  327. }
  328. // Loops over all nodes in the tree. On some errors, this may return early,
  329. // for example if an unrecoverable state is encountered.
  330. // NOLINTNEXTLINE(readability-function-size)
  331. auto CheckUnit::ProcessNodeIds() -> bool {
  332. NodeIdTraversal traversal(&context_);
  333. Parse::NodeId node_id = Parse::NodeId::None;
  334. // On crash, report which token we were handling.
  335. PrettyStackTraceFunction node_dumper([&](llvm::raw_ostream& output) {
  336. const auto& tree = tree_and_subtrees_getter_();
  337. auto converted = tree.NodeToDiagnosticLoc(node_id, /*token_only=*/false);
  338. converted.loc.FormatLocation(output);
  339. output << "Checking " << context_.parse_tree().node_kind(node_id) << "\n";
  340. // Crash output has a tab indent; try to indent slightly past that.
  341. converted.loc.FormatSnippet(output, /*indent=*/10);
  342. });
  343. while (auto maybe_node_id = traversal.Next()) {
  344. node_id = *maybe_node_id;
  345. emitter_.AdvanceToken(context_.parse_tree().node_token(node_id));
  346. if (context_.parse_tree().node_has_error(node_id)) {
  347. context_.TODO(node_id, "handle invalid parse trees in `check`");
  348. return false;
  349. }
  350. bool result;
  351. auto parse_kind = context_.parse_tree().node_kind(node_id);
  352. switch (parse_kind) {
  353. #define CARBON_PARSE_NODE_KIND(Name) \
  354. case Parse::NodeKind::Name: { \
  355. result = HandleParseNode( \
  356. context_, context_.parse_tree().As<Parse::Name##Id>(node_id)); \
  357. break; \
  358. }
  359. #include "toolchain/parse/node_kind.def"
  360. }
  361. if (!result) {
  362. CARBON_CHECK(
  363. unit_and_imports_->err_tracker.seen_error(),
  364. "HandleParseNode for `{0}` returned false without diagnosing.",
  365. parse_kind);
  366. return false;
  367. }
  368. traversal.Handle(parse_kind);
  369. }
  370. return true;
  371. }
  372. auto CheckUnit::CheckRequiredDeclarations() -> void {
  373. for (const auto& function : context_.functions().values()) {
  374. if (!function.first_owning_decl_id.has_value() &&
  375. function.extern_library_id == context_.sem_ir().library_id()) {
  376. auto function_import_id =
  377. context_.insts().GetImportSource(function.non_owning_decl_id);
  378. CARBON_CHECK(function_import_id.has_value());
  379. auto import_ir_id =
  380. context_.sem_ir().import_ir_insts().Get(function_import_id).ir_id();
  381. auto& import_ir = context_.import_irs().Get(import_ir_id);
  382. if (import_ir.sem_ir->package_id().has_value() !=
  383. context_.sem_ir().package_id().has_value()) {
  384. continue;
  385. }
  386. CARBON_DIAGNOSTIC(
  387. MissingOwningDeclarationInApi, Error,
  388. "owning declaration required for non-owning declaration");
  389. if (!import_ir.sem_ir->package_id().has_value() &&
  390. !context_.sem_ir().package_id().has_value()) {
  391. emitter_.Emit(function.non_owning_decl_id,
  392. MissingOwningDeclarationInApi);
  393. continue;
  394. }
  395. if (import_ir.sem_ir->identifiers().Get(
  396. import_ir.sem_ir->package_id().AsIdentifierId()) ==
  397. context_.sem_ir().identifiers().Get(
  398. context_.sem_ir().package_id().AsIdentifierId())) {
  399. emitter_.Emit(function.non_owning_decl_id,
  400. MissingOwningDeclarationInApi);
  401. }
  402. }
  403. }
  404. }
  405. auto CheckUnit::CheckRequiredDefinitions() -> void {
  406. CARBON_DIAGNOSTIC(MissingDefinitionInImpl, Error,
  407. "no definition found for declaration in impl file");
  408. for (SemIR::InstId decl_inst_id : context_.definitions_required_by_decl()) {
  409. SemIR::Inst decl_inst = context_.insts().Get(decl_inst_id);
  410. CARBON_KIND_SWITCH(context_.insts().Get(decl_inst_id)) {
  411. case CARBON_KIND(SemIR::ClassDecl class_decl): {
  412. if (!context_.classes().Get(class_decl.class_id).is_complete()) {
  413. emitter_.Emit(decl_inst_id, MissingDefinitionInImpl);
  414. }
  415. break;
  416. }
  417. case CARBON_KIND(SemIR::FunctionDecl function_decl): {
  418. if (context_.functions().Get(function_decl.function_id).definition_id ==
  419. SemIR::InstId::None) {
  420. emitter_.Emit(decl_inst_id, MissingDefinitionInImpl);
  421. }
  422. break;
  423. }
  424. case CARBON_KIND(SemIR::ImplDecl impl_decl): {
  425. auto& impl = context_.impls().Get(impl_decl.impl_id);
  426. if (!impl.is_complete()) {
  427. FillImplWitnessWithErrors(context_, impl);
  428. CARBON_DIAGNOSTIC(ImplMissingDefinition, Error,
  429. "impl declared but not defined");
  430. emitter_.Emit(decl_inst_id, ImplMissingDefinition);
  431. }
  432. break;
  433. }
  434. case SemIR::InterfaceDecl::Kind: {
  435. // TODO: Handle `interface` as well, once we can test it without
  436. // triggering
  437. // https://github.com/carbon-language/carbon-lang/issues/4071.
  438. CARBON_FATAL("TODO: Support interfaces in DiagnoseMissingDefinitions");
  439. }
  440. default: {
  441. CARBON_FATAL("Unexpected inst in definitions_required_by_decl: {0}",
  442. decl_inst);
  443. }
  444. }
  445. }
  446. for (auto [loc, specific_id] :
  447. GrowingRange(context_.definitions_required_by_use())) {
  448. // This is using the location for the use. We could track the
  449. // list of enclosing locations if this was used from a generic.
  450. if (!ResolveSpecificDefinition(context_, loc, specific_id)) {
  451. CARBON_DIAGNOSTIC(MissingGenericFunctionDefinition, Error,
  452. "use of undefined generic function");
  453. CARBON_DIAGNOSTIC(MissingGenericFunctionDefinitionHere, Note,
  454. "generic function declared here");
  455. auto generic_decl_id =
  456. context_.generics()
  457. .Get(context_.specifics().Get(specific_id).generic_id)
  458. .decl_id;
  459. emitter_.Build(loc, MissingGenericFunctionDefinition)
  460. .Note(generic_decl_id, MissingGenericFunctionDefinitionHere)
  461. .Emit();
  462. }
  463. }
  464. }
  465. auto CheckUnit::CheckPoisonedConcreteImplLookupQueries() -> void {
  466. // Impl lookup can generate instructions (via deduce) which we don't use, as
  467. // we're only generating diagnostics here, so we catch and discard them.
  468. context_.inst_block_stack().Push();
  469. auto poisoned_queries =
  470. std::exchange(context_.poisoned_concrete_impl_lookup_queries(), {});
  471. for (const auto& poison : poisoned_queries) {
  472. auto witness_result = EvalLookupSingleImplWitness(
  473. context_, poison.loc_id, poison.query, poison.query.query_self_inst_id,
  474. EvalImplLookupMode::RecheckPoisonedLookup);
  475. CARBON_CHECK(witness_result.has_final_value());
  476. auto found_witness_id = witness_result.final_witness();
  477. if (found_witness_id == SemIR::ErrorInst::InstId) {
  478. // Errors may have been diagnosed with the impl used in the poisoned query
  479. // in the meantime (such as a missing definition).
  480. continue;
  481. }
  482. if (found_witness_id != poison.impl_witness) {
  483. auto witness_to_impl_id = [&](SemIR::InstId witness_id) {
  484. auto table_id = context_.insts()
  485. .GetAs<SemIR::ImplWitness>(witness_id)
  486. .witness_table_id;
  487. return context_.insts()
  488. .GetAs<SemIR::ImplWitnessTable>(table_id)
  489. .impl_id;
  490. };
  491. // We can get the `Impl` from the resulting witness here, which is the
  492. // `Impl` that conflicts with the previous poison query.
  493. auto bad_impl_id = witness_to_impl_id(found_witness_id);
  494. const auto& bad_impl = context_.impls().Get(bad_impl_id);
  495. auto prev_impl_id = witness_to_impl_id(poison.impl_witness);
  496. const auto& prev_impl = context_.impls().Get(prev_impl_id);
  497. CARBON_DIAGNOSTIC(
  498. PoisonedImplLookupConcreteResult, Error,
  499. "found `impl` that would change the result of an earlier "
  500. "use of `{0} as {1}`",
  501. InstIdAsRawType, SpecificInterfaceIdAsRawType);
  502. auto builder =
  503. emitter_.Build(poison.loc_id, PoisonedImplLookupConcreteResult,
  504. poison.query.query_self_inst_id,
  505. poison.query.query_specific_interface_id);
  506. CARBON_DIAGNOSTIC(
  507. PoisonedImplLookupConcreteResultNoteBadImpl, Note,
  508. "the use would select the `impl` here but it was not found yet");
  509. builder.Note(bad_impl.first_decl_id(),
  510. PoisonedImplLookupConcreteResultNoteBadImpl);
  511. CARBON_DIAGNOSTIC(PoisonedImplLookupConcreteResultNotePreviousImpl, Note,
  512. "the use had selected the `impl` here");
  513. builder.Note(prev_impl.first_decl_id(),
  514. PoisonedImplLookupConcreteResultNotePreviousImpl);
  515. builder.Emit();
  516. }
  517. }
  518. context_.inst_block_stack().PopAndDiscard();
  519. }
  520. auto CheckUnit::CheckImpls() -> void { ValidateImplsInFile(context_); }
  521. auto CheckUnit::FinishRun() -> void {
  522. CheckRequiredDeclarations();
  523. CheckRequiredDefinitions();
  524. CheckPoisonedConcreteImplLookupQueries();
  525. CheckImpls();
  526. // Finalizes the C++ portion of the compilation.
  527. FinishAst(context_);
  528. // Pop information for the file-level scope.
  529. context_.sem_ir().set_top_inst_block_id(context_.inst_block_stack().Pop());
  530. context_.scope_stack().Pop();
  531. // Finalizes the list of exports on the IR.
  532. context_.inst_blocks().ReplacePlaceholder(SemIR::InstBlockId::Exports,
  533. context_.exports());
  534. // Finalizes the ImportRef inst block.
  535. context_.inst_blocks().ReplacePlaceholder(SemIR::InstBlockId::Imports,
  536. context_.imports());
  537. // Finalizes __global_init.
  538. context_.global_init().Finalize();
  539. context_.sem_ir().set_has_errors(unit_and_imports_->err_tracker.seen_error());
  540. // Verify that Context cleanly finished.
  541. context_.VerifyOnFinish();
  542. }
  543. } // namespace Carbon::Check